Skip to content

[OGUI-1903] Fix multiline select and copying - #3582

Open
isaachilly wants to merge 4 commits into
devfrom
bug/ILG/OGUI-1903/Copy-select-has-new-lines-issue
Open

[OGUI-1903] Fix multiline select and copying#3582
isaachilly wants to merge 4 commits into
devfrom
bug/ILG/OGUI-1903/Copy-select-has-new-lines-issue

Conversation

@isaachilly

@isaachilly isaachilly commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

@isaachilly isaachilly self-assigned this Aug 20, 2026
@isaachilly isaachilly changed the title [OGUI-1903] Fix multiline select and copy big [OGUI-1903] Fix multiline select and copying Aug 20, 2026
@isaachilly
isaachilly force-pushed the bug/ILG/OGUI-1903/Copy-select-has-new-lines-issue branch 2 times, most recently from 6dbe66d to 46d41a4 Compare August 21, 2026 09:28
Simplifies log cell markup by removing `.cell-content` and `.cell-text` wrappers so text sits directly in `<td>`, avoiding extra line breaks when copying multi-row selections.

Thus updates `.cell` styling to handle truncation directly and repositions the context-menu hint as an absolute, non-selectable overlay so it doesn't get copied.
Add new test covering bug.

Extract shared Puppeteer log/table helpers into a reusable test utility.

Update context-menu assertions to read cell text from `td.cell`.
@isaachilly
isaachilly force-pushed the bug/ILG/OGUI-1903/Copy-select-has-new-lines-issue branch from 46d41a4 to 42300a4 Compare August 21, 2026 15:10
@isaachilly
isaachilly marked this pull request as ready for review August 21, 2026 15:12
@isaachilly
isaachilly requested a review from graduta as a code owner August 21, 2026 15:12

@graduta graduta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. For the future PRs, please make sure you add a description to the ticket.
For this particular change, it would have been good to add an example of description of the reported user bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants